Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FC-0068 docs: How-to cleaning by edunext #10 #715

Merged
merged 11 commits into from
Jan 9, 2025
Merged

FC-0068 docs: How-to cleaning by edunext #10 #715

merged 11 commits into from
Jan 9, 2025
+383 −245

Conversation

Apgomeznext
Copy link
Contributor

This PR modifies a series of how-to documents migrated from the legacy repositories to the educators' documentation. Also creates some how-tos from the cohorted_courseware document.

@Apgomeznext
FC-0068 docs: How-to cleaning by edunext openedx#10
dd78db3 
This PR modifies a series of how-to documents migrated from the legacy repositories to the educators' documentation.  Also creates some how-tos from the cohorted_courseware document.
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 31, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Dec 31, 2024 •
edited
Loading

Thanks for the pull request, @Apgomeznext!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/docs-openedx-org-maintainers. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@Apgomeznext Apgomeznext marked this pull request as ready for review December 31, 2024 14:46
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Jan 2, 2025
sarina
sarina approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@sarina sarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BryanttV can you resolve the conflicts in this PR?

source/educators/how-tos/advanced_features/associate_cohort_with_groups.rst Outdated Show resolved Hide resolved
source/educators/how-tos/advanced_features/lti_determine_content_address.rst Outdated Show resolved Hide resolved
source/educators/how-tos/advanced_features/lti_determine_content_address.rst Outdated Show resolved Hide resolved
source/educators/how-tos/advanced_features/lti_determine_content_address.rst Outdated Show resolved Hide resolved
source/educators/how-tos/advanced_features/lti_determine_content_address.rst Outdated Show resolved Hide resolved
source/educators/how-tos/advanced_features/lti_determine_content_address.rst Outdated Show resolved Hide resolved
source/educators/how-tos/advanced_features/lti_determine_content_address.rst Outdated Show resolved Hide resolved
source/educators/how-tos/advanced_features/lti_determine_content_address.rst Outdated Show resolved Hide resolved
source/educators/how-tos/advanced_features/lti_determine_content_address.rst Outdated Show resolved Hide resolved
source/educators/how-tos/advanced_features/lti_determine_content_address.rst Outdated Show resolved Hide resolved
@Apgomeznext
Copy link
Contributor Author

@sarina, the conflicts with this PR has been solved and can be merge :)

@sarina sarina merged commit 95ce07d into openedx:main Jan 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarina sarina sarina approved these changes

Assignees
No one assigned
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Apgomeznext @openedx-webhooks @sarina @mphilbrick211